I have to say, from a general fitness and general strength standpoint, crossfit is great. The workouts are simple and full of basic exercises. You will gain strength, but you will not be a weightlifter or powerlifter. You will gain endurance, but you will not be a marathon runner.
To go with what limestix is saying, problems arise if you "drink too much of the Kool Aid" and stop thinking for yourself. Most CrossFit people I know do not always do exactly what the WOD's are, but variations depending upon what they need and their ability level.
There is a faction within the CrossFit community who view training until injury as some sort of badge of honor. Things like doing pull-ups until the skin peels off your hand, or incurring any number if overuse injuries is looked at like you are so hardcore that you can literally train to the complete edge of your ability. That viewpoint is crazy, though I have met very few people who fit in this category.
In all, crossfit people are in excellent condition, are very lean, and pretty strong.
If you are looking for general strength and fitness packaged in a simple way, it will work great for you.
Just don't blindly follow the CrossFit programs without thinking a bit for yourself.