anything wrong..

[deae1]

monday
chest,tri
push ups,dips
bench press 3x10
incline press 3x10
skull crushers 3x10
tricep extension 3x10

wednesday
back,biceps
chin ups 3x12
bent over rows 3x12
good mornings 3x12
preacher curls 2x12

friday
shoulders ,legs
upright rows 3x12
over head press 3x12
laterial raise 3x12
shrugs 1x20
calf raises 3x20
squats 3x10

breakfast
bowl of cherios with milk,protein shake with milk

lunch
3 scrambled eggs and some fruit

snack
penut butter jelly on whole wheat bread

dinner
either chicken or hamburgers with salad

before bed
can of tuna with lemon or mayo

8hours of sleep a night
1 gallon of water a day

 

[Adler1983]

Diet: Looks good; add one more snack between breakfast and lunch. Some may say the cheerio's is a bad move; I like it. You could though switch to fiber one or Kashi Crunch (Fiber one has loads of fiber and Kashi Crunch has loads of protein...your call). Make sure those hamburgers are lean; not the store bought patties. Make your own with lean ground beef.

Routine: Looks good too. I've recently (last 6 months) have become a proponent of full body workouts 3 days a week or a 2lower 2upper/week workouts. I've seen a lot of research that suggests volume training is more effective. But if you're going to do splits like the ones you have posted put flat bench first; upright rows are more of a back exercise than shoulders but since you have a day in between all your workouts this won't be a detriment to you; ALWAYS start with squats/legs. You want to work all your days from biggest muscle to smallest. So on your shoulder leg day follow this progression:

squats 3x10
upright rows 3x12
over head press 3x12
laterial raise 3x12
shrugs 1x20
calf raises 3x20

You're done well here focusing on big, compound, power movements that challenge a multitude of primary and secondary movers and stabilizers.

Good luck bro!